Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ci skip] Enhanced Rdoc for Hash #3151

Merged
merged 1 commit into from May 28, 2020
Merged

[ci skip] Enhanced Rdoc for Hash #3151

merged 1 commit into from May 28, 2020

Conversation

BurdetteLamar
Copy link
Member

Rdoc updated for methods:

  • #each_value
  • #each_key
  • #each and #each_pair
  • #transform_keys
  • #transform_keys!
  • #transform_values
  • #transform_values!

@BurdetteLamar BurdetteLamar added the Documentation Improvements to documentation. label May 27, 2020
ioquatix
ioquatix reviewed May 28, 2020
View reviewed changes
hash.c
* h = {foo: 0, bar: 1, baz: 2}
* h1 = h.each_value {|value| puts value }
* h1 # => {:foo=>0, :bar=>1, :baz=>2}
* h1.equal?(h) # => true # Identity check
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand why this is logical, but I'm not sure what it adds. It seems like a distraction?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shows that it's +self+ that's returned. (But elsewhere I did not show that the return is a new Hash).

ioquatix
ioquatix approved these changes May 28, 2020
View reviewed changes
Copy link
Member

@ioquatix ioquatix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work.

@BurdetteLamar BurdetteLamar merged commit 28ce758 into ruby:master May 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ioquatix ioquatix ioquatix approved these changes

Assignees
No one assigned
Labels
Documentation Improvements to documentation.
Milestone
No milestone
2 participants
@BurdetteLamar @ioquatix