Make rb_define_module{,_id}_under pin like rb_define_class{,_id}_under #3885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just like rb_define_class_id_under(). Also makes rb_define_module_under() consistent with rb_define_class_under() in the same regard.
XrXr
commented
Dec 11, 2020
| @@ -908,6 +916,8 @@ rb_define_module_id_under(VALUE outer, ID id) | |||
| " (%"PRIsVALUE")", | |||
| outer, rb_id2str(id), rb_obj_class(module)); | |||
| } | |||
| /* Module may have been defined in Ruby and not pin-rooted */ | |||
| rb_gc_register_mark_object(module); | |||
There was a problem hiding this comment.
By the way, rb_vm_add_root_module() now seems to serve exactly the same purpose as rb_gc_register_mark_object(). They both root and pin. Maybe we can delete rb_vm_add_root_module() since it's not a public API.
rb_gc_register_mark_object uses an array of arrays and rb_vm_add_root_module() uses an st_table.
There was a problem hiding this comment.
I think we can. AFAIK the array of arrays is to prevent bloating (but I am just guessing). I think it would be better to use that than an st_table.
XrXr
force-pushed
the
module-class-compaction
branch
from
8b83e28
to
41af467
Compare
tenderlove
approved these changes
Jan 27, 2021
| @@ -908,6 +916,8 @@ rb_define_module_id_under(VALUE outer, ID id) | |||
| " (%"PRIsVALUE")", | |||
| outer, rb_id2str(id), rb_obj_class(module)); | |||
| } | |||
| /* Module may have been defined in Ruby and not pin-rooted */ | |||
| rb_gc_register_mark_object(module); | |||
There was a problem hiding this comment.
I think we can. AFAIK the array of arrays is to prevent bloating (but I am just guessing). I think it would be better to use that than an st_table.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And add docs. The change makes these APIs consistent when it comes to pinning objects they return.