Clarify SecureRandom#hex documentation. #394
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
| @@ -116,10 +116,10 @@ def self.random_bytes(n=nil) | |||
| raise NotImplementedError, "No random device" | |||
| end | |||
|
|
|||
| # SecureRandom.hex generates a random hex string. | |||
| # SecureRandom.hex generates a random hexidecimal string. | |||
There was a problem hiding this comment.
Not trying to be Mr. Smartypants, but you have a typo here :-)
There was a problem hiding this comment.
Ah, google tells me it is "hexadecimal".
mmasaki
pushed a commit
to mmasaki/ruby
that referenced
this pull request
Oct 6, 2013
[Fixes rubyGH-394] Patch by @avdi ruby#394 git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@42991 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
tenderlove
pushed a commit
to tenderlove/ruby
that referenced
this pull request
Jan 24, 2014
[Fixes rubyGH-394] Patch by @avdi ruby#394 git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@42991 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
hsbt
pushed a commit
to ruby/securerandom
that referenced
this pull request
May 22, 2020
[Fixes GH-394] Patch by @avdi ruby/ruby#394 git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@42991 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.