Fix build failure on macOS with --enable-shared #4776
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
./spec/ruby/optional/capi/ext/array_spec.c can match with spec/%/ if using GNU Make under version 3.81. make command installed on macOS is 3.81, so ruby can't be built with default make on macOS with --enable-shared option since ruby@bda56a0
nobu
requested changes
Aug 25, 2021
This would avoid unintentional use of the `NOOP` environment variable Co-authored-by: Nobuyoshi Nakada <nobu@ruby-lang.org>
nobu
approved these changes
Aug 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
./spec/ruby/optional/capi/ext/array_spec.ccan match withspec/%/ifusing GNU Make under version 3.81. make command installed on macOS is
3.81, so ruby can't be built with default make on macOS with
--enable-shared option since bda56a0
This patch repairs ruby-dev-builder's daily builds