Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.github/workflows/compilers.yml: Use GNUMAKEFLAGS. #4880

Merged
merged 1 commit into from Sep 23, 2021

Conversation

junaruga
Copy link
Member

This PR comes from #4875 (comment) .

Because the make environment variable causes some rubygems tests to fail.
And to align with .cirrus.yml.

I also tested with check: true on my forked repo, as currently there is no test enabling check: true. And here is the CI result.

-          - { key: default_cc, name: gcc-11,    value: gcc-11,    container: gcc-11 }
+          - { key: default_cc, name: gcc-11,    value: gcc-11,    container: gcc-11, check: true }
...
-          - { key: default_cc, name: clang-14,  value: clang-14,  container: clang-14 }
+          - { key: default_cc, name: clang-14,  value: clang-14,  container: clang-14, check: true }

Because the `make` environment variable causes some rubygems tests to fail.
And to align with `.cirrus.yml`.
@junaruga
Copy link
Member Author

The each case's total running time is around 4+ minutes. It's same level with the previous one.
https://github.com/ruby/ruby/pull/4880/checks?check_run_id=3672941483

Copy link
Member

@shyouhei shyouhei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:LGTM: !!

@junaruga junaruga merged commit e6118c8 into ruby:master Sep 23, 2021
@junaruga junaruga deleted the wip/gha-compilers-make branch September 23, 2021 08:21
@junaruga
Copy link
Member Author

Thanks for reviewing!

shyouhei added a commit to shyouhei/ruby that referenced this pull request Oct 22, 2021
shyouhei added a commit that referenced this pull request Oct 26, 2021
A bit readable to me.
See also #4880
hsbt pushed a commit to hsbt/ruby that referenced this pull request Feb 7, 2023
hsbt pushed a commit to hsbt/ruby that referenced this pull request Mar 28, 2023
unak pushed a commit that referenced this pull request Mar 29, 2023
A bit readable to me.
See also #4880
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants