Enhanced RDoc for Enumerable #4910
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremyevans
requested changes
Sep 29, 2021
enum.c
Outdated
| * <i>enum</i> that correspond to the minimum and maximum values respectively | ||
| * from the given block. | ||
| * Returns a 2-element array containing the elements | ||
| * for which the block returns minimum an maximum values: |
There was a problem hiding this comment.
minimum an maximum -> minimum and maximum
JuPlutonic
reviewed
Sep 29, 2021
| * With a block given and no argument, | ||
| * returns the maximum element as determined by the block: | ||
| * | ||
| * %w[xxx x xxxx xx].max {|a, b| a.size <=> b.size } # => "xxxx" |
There was a problem hiding this comment.
suggestion:
{foo: 0, bar: 1, baz: 2}.max {|pair1, pair2| pair1[1] <=> pair2[1] }
# => [:baz, 2]
JuPlutonic
reviewed
Sep 29, 2021
| * returns an array containing the first +n+ maximum elements that exist, | ||
| * as determined by the block. | ||
| * | ||
| * %w[xxx x xxxx xx].max(2) {|a, b| a.size <=> b.size } # => ["xxxx", "xxx"] |
There was a problem hiding this comment.
suggestion:
{foo: 0, bar: 1, baz: 2}.max(2) {|pair1, pair2| pair1[1] <=> pair2[1] }
# => [[:baz, 2], [:bar, 1]]
JuPlutonic
reviewed
Sep 29, 2021
| * With a block given, returns the minimum and maximum elements | ||
| * as determined by the block: | ||
| * | ||
| * %w[xxx x xxxx xx].minmax {|a, b| a.size <=> b.size } # => ["x", "xxxx"] |
There was a problem hiding this comment.
suggestion:
{foo: 0, bar: 1, baz: 2}.minmax {|pair1, pair2| pair1[1] <=> pair2[1] }
# => [[:foo, 0], [:baz, 2]]
|
Thanks, @JuPlutonic, I will look at these comments. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Treats: