New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhanced RDoc for Enumerable #4918
Conversation
@jeremyevans, thoughts:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Only a couple of minor changes requested for the zip call-seq.
@jeremyevans, any thoughts on these? |
No strong feelings about either. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Miscellaneous checks CI is failing due to trailing spaces added in the zip
call-seq, so you need to fix that before merging:
enum.c:3171: * zip(*other_enums) → array
enum.c:3172: * zip(*other_enums) {|array| ... } → nil
After that is fixed and CI passes, OK to merge without further review.
* r.take(2) # => [1, 2] | ||
* r.take(0) # => [] | ||
* | ||
* h = {foo:0, bar: 1, baz: 2, bat: 3} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add space between first key and value
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added.
* a = h.take_while{|element| key, value = *element; value < 2 } | ||
* a # => [[:foo, 0], [:bar, 1]] | ||
* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a variable not needed in these two lines, please remove it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed.
Treats: