Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This extracts the logic previously inside
gen_putobject
to a more reusable helper methodjit_putobject
.The motivation for this is that it both simplifies the implementation of other instructions, and other instructions can reuse the optimized behaviour for 32-bit special constants (most importantly
opt_getinlinecache
).This commit also expands the optimization to use a
mov
directly to memory when we encounter a 32-bit immediate constant. Previously it covered fixnums andQtrue
/Qfalse
, now it will cover anySPECIAL_CONST_P
value which can be represented as a 32-bit immediate. Notably, this includes static symbols, and Qnil.Sample disassembly
putobject with static symbol
Before:
After:
getinlinecache
Before:
After: