Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename --jit to --mjit #5248

Merged
merged 7 commits into from Dec 14, 2021
Merged

Rename --jit to --mjit #5248

merged 7 commits into from Dec 14, 2021

Conversation

k0kubun
Copy link
Member

@k0kubun k0kubun commented Dec 12, 2021

[Feature #18349]

  • Rename --jit to --mjit
  • Rename --(enable|disable)[-=]jit to --(enable|disable)[-=]mjit
  • Add --jit as an alias to --yjit on non-Windows x86-64, or --mjit on others.
  • Add --(enable|disable)[-=]jit as an alias to enable/disable yjit or mjit in the same manner.

This PR handles only command-line options. Renaming RubyVM::JIT back to RubyVM::MJIT will be handled in another PR.

[Feature #18349]
@k0kubun k0kubun marked this pull request as ready for review December 13, 2021 18:54
Copy link
Member

@XrXr XrXr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

%w(--version --disable=jit --yjit),
%w(--version --disable=jit --enable-jit),
%w(--version --disable=jit --enable=jit),
] if RUBY_PLATFORM.start_with?('x86_64-') && RUBY_PLATFORM !~ /mswin|mingw|msys/),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Off topic, maybe in the future YJIT wants a YJIT_SUPPORT key similar to MJIT.

@k0kubun k0kubun merged commit 11b8aaa into ruby:master Dec 14, 2021
@k0kubun k0kubun deleted the mjit-flags branch December 14, 2021 00:08
hsbt pushed a commit to hsbt/ruby that referenced this pull request Feb 7, 2023
* Rename --jit to --mjit

[Feature #18349]

* Fix a few more --jit references

* Fix MJIT Actions

* More s/jit/mjit/ and re-introduce --disable-jit

* Update NEWS.md

* Fix test_bug_reporter_add
hsbt pushed a commit to hsbt/ruby that referenced this pull request Mar 28, 2023
* Rename --jit to --mjit

[Feature #18349]

* Fix a few more --jit references

* Fix MJIT Actions

* More s/jit/mjit/ and re-introduce --disable-jit

* Update NEWS.md

* Fix test_bug_reporter_add
unak pushed a commit that referenced this pull request Mar 29, 2023
* Rename --jit to --mjit

[Feature #18349]

* Fix a few more --jit references

* Fix MJIT Actions

* More s/jit/mjit/ and re-introduce --disable-jit

* Update NEWS.md

* Fix test_bug_reporter_add
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants