New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document Fiber::SchedulerInterface#io_read
and #io_write
#5280
Conversation
@ioquatix Please review. Should other details be mentioned? Is the description correct overall? |
This looks good.
|
Please mark/tag |
I had to make some internal changes to the hooks, I will have some updates to this documentation in a day or two. |
@ioquatix Is that what you had in mind? I am not sure—maybe I am lost a bit—whether the new interface is expected to return "length or -errno" (how I described it) or |
Yes, this interface can return an integer in the range of I provided C interface to hide exact implementation details of the FYI Linux internally follows this model and libc writes the return value to |
@zverok thanks so much for helping with this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 This is great.
00d3fc3
to
0afc515
Compare
0afc515
to
6e03ec9
Compare
@ioquatix I've applied your suggestions, thanks! 🤗 |
I wonder if it would make sense to move this pseudo-implementation to |
Screenshot (ignore
#io_wait
):