Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC] What's Here for ENV #5292

Merged
merged 2 commits into from Dec 18, 2021
Merged

[DOC] What's Here for ENV #5292

merged 2 commits into from Dec 18, 2021

Conversation

BurdetteLamar
Copy link
Member

No description provided.

@BurdetteLamar BurdetteLamar added the Documentation Improvements to documentation. label Dec 17, 2021
Copy link
Contributor

@jeremyevans jeremyevans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Up to you if you want to mention that ENV extends Enumerable, but I would recommend doing so. No need for further review.

* First, what's elsewhere. \Class \ENV:
*
* - Inherits from {class Object}[Object.html#class-Object-label-What-27s+Here].
*
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here is where you would usually list that ENV extends Enumerable, I think.

@nobu
Copy link
Member

nobu commented Dec 18, 2021

Could you prefix the commit message with [DOC] at merging?

@BurdetteLamar BurdetteLamar merged commit 7e0e6f9 into ruby:master Dec 18, 2021
@nobu
Copy link
Member

nobu commented Dec 19, 2021

I meant the top of the whole message including the first line, or the title of the pull request.

@BurdetteLamar BurdetteLamar changed the title What's Here for ENV [DOC] What's Here for ENV Dec 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Improvements to documentation.
3 participants