Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DOC] Fix String#unpack and #unpack1 docs #5331

Merged
merged 1 commit into from Dec 23, 2021
Merged

[DOC] Fix String#unpack and #unpack1 docs #5331

merged 1 commit into from Dec 23, 2021

Conversation

zverok
Copy link
Contributor

@zverok zverok commented Dec 23, 2021

  • New offset: argument examples were introduced too early in the docs, before the main examples/explanations.
  • #unpack1 also had formatting glitch.

Screenshot (of #unpack1 only, #unpacks too long):
image

@zverok
Copy link
Contributor Author

zverok commented Dec 23, 2021

@byroot Please review

byroot
byroot approved these changes Dec 23, 2021
View reviewed changes
Copy link
Member

@byroot byroot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Do you need me to merge?

@zverok
Copy link
Contributor Author

zverok commented Dec 23, 2021

@byroot Well, probably we need it to be merged, let's put it this way (and I don't have commiter rights 🤷 )

@byroot
Copy link
Member

byroot commented Dec 23, 2021

and I don't have commiter rights 🤷

That was my question :)

@byroot byroot merged commit 0b999be into ruby:master Dec 23, 2021
@zverok zverok deleted the docs-fix-string-unpack branch December 23, 2021 23:39
@zverok zverok added the Documentation Improvements to documentation. label Dec 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@byroot byroot byroot approved these changes

Assignees
No one assigned
Labels
Documentation Improvements to documentation.
Milestone
No milestone
2 participants
@zverok @byroot