Add IO#timeout attribute and use it for blocking IO operations. #5653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ioquatix
force-pushed
the
io-timeout
branch
8 times, most recently
from
7c695e8
to
8f5a57e
Compare
ioquatix
force-pushed
the
io-timeout
branch
2 times, most recently
from
1145393
to
5509ca0
Compare
ioquatix
force-pushed
the
io-timeout
branch
2 times, most recently
from
e1be1c4
to
28890f0
Compare
ioquatix
force-pushed
the
io-timeout
branch
13 times, most recently
from
1b6a908
to
4070940
Compare
ioquatix
force-pushed
the
io-timeout
branch
9 times, most recently
from
5212173
to
2361573
Compare
|
Consider the backward compatibility of ruby/openssl. |
ioquatix
force-pushed
the
io-timeout
branch
2 times, most recently
from
2f8b0df
to
2e57446
Compare
ioquatix
force-pushed
the
io-timeout
branch
2 times, most recently
from
6438434
to
32e1a4f
Compare
ko1
reviewed
Oct 7, 2022
|
|
||
| /** | ||
| * Set the timeout associated with the specified io object. This timeout is | ||
| * used as a best effort timeout to prevent operations from blocking forever. |
There was a problem hiding this comment.
I recommend to denote examples like "socket read/write".
There was a problem hiding this comment.
ah, it's not a description for the method.
There was a problem hiding this comment.
Sorry, I don't fully understand your feedback, but I'm happy to improve the documentation.
|
I have a follow up PR to improve the usage for backwards compatible extensions: #6507 |
|
Update to openssl gem: ruby/openssl#547 |
eregon
reviewed
May 29, 2023
| @@ -14,14 +14,22 @@ | |||
| } | |||
| end | |||
|
|
|||
| ruby_version_is "3.0" do | |||
| ruby_version_is "3.0"..."3.1" do | |||
There was a problem hiding this comment.
Should have been ..."3.2", fixed in ruby/spec@c3677cf
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugs.ruby-lang.org/issues/18630