Introduce encoding check macro #6700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nobu
reviewed
Nov 9, 2022
Comment on lines
1058
to
1060
| #define is_usascii_enc(enc) (enc) == rb_usascii_encoding() | ||
| #define is_ascii8bit_enc(enc) (enc) == rb_ascii8bit_encoding() | ||
| #define is_locale_enc(enc) (enc) == rb_locale_encoding() |
There was a problem hiding this comment.
Since these macros seem not used under ext or include, isn't internal/encoding.h better?
Or, should be prefixed at least.
There was a problem hiding this comment.
Thanks!
Added rb_ prefix and move to internal/encoding.h in f29a25a
S-H-GAMELINKS
force-pushed
the
introduce/encoding_check_macro
branch
4 times, most recently
from
002d767
to
3e15b42
Compare
S-H-GAMELINKS
force-pushed
the
introduce/encoding_check_macro
branch
2 times, most recently
from
ea45c3a
to
ba67de9
Compare
|
In general, it is safer to parenthesize macro expressions. |
S-H-GAMELINKS
force-pushed
the
introduce/encoding_check_macro
branch
from
ba67de9
to
ede6565
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some code has encoding check that using
rb_usascii_encoding,rb_ascii8bit_encodingandrb_locale_encodingfunctions.But, bit longer I thought.
So, I thought better to introduce encoding check macro like a
is_ascii_stringfunction to more shorter and simpler.