Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing OP_CCLASS_MB case in init_cache_table_index #6744

Merged
merged 2 commits into from Nov 17, 2022

Conversation

makenowjust
Copy link
Contributor

Fix https://bugs.ruby-lang.org/issues/19104#note-4 report.

The reason for this bug is that the line case OP_CCLASS_MB: is missing in the function init_cache_table_index.
Thank you @byroot for report!

@makenowjust makenowjust changed the title Add OP_CCLASS_MB case Add missing OP_CCLASS_MB case in init_cache_table_index Nov 16, 2022
@byroot
Copy link
Member

byroot commented Nov 16, 2022

Thank you. I just triggered another CI build with this patch. I'll report back in ~30m.

Copy link
Member

@byroot byroot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Our CI is now all green with this patch. Thank you!

@eregon
Copy link
Member

eregon commented Nov 16, 2022

Wouldn't it be safer to add a default: case in the switch and rb_bug() or some fallback in there?

@makenowjust
Copy link
Contributor Author

@eregon I'm not sure calling rb_bug() from Onigmo code is possible or good practice. I added to return ONIGERR_UNDEFINED_BYTECODE or ONIGERR_UNEXPECTED_BYTECODE instead.

@mame mame merged commit 189e3c0 into ruby:master Nov 17, 2022
@makenowjust makenowjust deleted the add-case-mbclass branch April 20, 2023 02:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
4 participants