Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

YJIT: Implement opt_newarray_max instruction #6893

Merged
merged 1 commit into from Dec 12, 2022

Conversation

k0kubun
Copy link
Member

@k0kubun k0kubun commented Dec 9, 2022

Almost the same thing as #6888.

Prior to this PR, some benchmarks were exiting on opt_newarray_max:

benchmark ratio_in_yjit opt_newarray_max: exit reasons %
activerecord 88.8% 0
hexapdf 82.9% 17.3%
liquid-render 86.8% 0
mail 98.9% 4%
psych-load 100% 0
railsbench 92.9% 0.0%
ruby-lsp 68.7% 0.8%

This does seem to help the hexapdf benchmark a little:

before: ruby 3.2.0dev (2022-12-09T22:12:15Z master daa893db41) +YJIT [x86_64-linux]
after: ruby 3.2.0dev (2022-12-09T22:18:52Z yjit-newarray-max 356e80da95) +YJIT [x86_64-linux]

-------  -----------  ----------  ----------  ----------  ------------  -------------
bench    before (ms)  stddev (%)  after (ms)  stddev (%)  before/after  after 1st itr
hexapdf  1231.9       0.7         1190.7      1.0         1.03          1.03
-------  -----------  ----------  ----------  ----------  ------------  -------------

@matzbot matzbot requested a review from a team December 9, 2022 22:28
@maximecb maximecb merged commit ece6246 into ruby:master Dec 12, 2022
@maximecb maximecb deleted the yjit-newarray-max branch December 12, 2022 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants