YJIT: Make iseq_get_location consistent with iseq.c #7074
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've felt YJIT's disasm sometimes shows
None
where--dump=insns
would show the location just fine. It seems that YJIT uses#{iseq_path}:#{base_label}
while the rest of the CRuby code uses#{label}@#{iseq_path}:#{lineno}
for describing an iseq location. It seems more useful to use the common format, at least becauselabel
generally doesn't returnnil
unlikebase_label
.Before
After