YJIT: Add a few asm comments #7105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I also wanted this 19b9f0e, which shows something like |
maximecb
approved these changes
Jan 11, 2023
k0kubun
force-pushed
the
yjit-comments
branch
2 times, most recently
from
7ea47f8
to
b8824e7
Compare
k0kubun
force-pushed
the
yjit-comments
branch
from
b8824e7
to
3931d39
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I carved out a few asm comments from #7097 that I found helpful when developing that branch.
Insn:so that it will stand out more than random comments for that insn.Instruction:to make it look less significant / shorter thanBlock:.defer_compilationandupdate cfp->jit_return, which weren't obvious from the current disasm.