Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Two YJIT aesthetic refactorings #7121

Merged
merged 2 commits into from Jan 13, 2023
Merged

Two YJIT aesthetic refactorings #7121

merged 2 commits into from Jan 13, 2023

Conversation

XrXr
Copy link
Member

@XrXr XrXr commented Jan 13, 2023

  • YJIT: Factor out VALUE_BITS = (8 * SIZE_OF_VALUE as u8)
  • YJIT: Use SIZEOF_VALUE_I32 instead of ... as i32

@XrXr
YJIT: Factor out VALUE_BITS = (8 * SIZE_OF_VALUE as u8)
cfc2cc7 
Using a constant shows intention better and is less noisy. It always
took me a second to parse the long expression.
@XrXr
YJIT: Use SIZEOF_VALUE_I32 instead of ... as i32
d022671 
Shorter, and easier to parse without parentheses.
@matzbot matzbot requested a review from a team January 13, 2023 19:42
@XrXr XrXr merged commit b4cdde4 into ruby:master Jan 13, 2023
@XrXr XrXr deleted the yjit-gcse branch January 13, 2023 20:32
@k0kubun k0kubun mentioned this pull request Jan 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@k0kubun k0kubun k0kubun approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
2 participants
@XrXr @k0kubun