Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

YJIT: Set RUST_BACKTRACE=1 on YJIT GitHub Actions #7152

Merged
merged 1 commit into from Jan 19, 2023

Conversation

k0kubun
Copy link
Member

@k0kubun k0kubun commented Jan 19, 2023

panic on GitHub Actions currently doesn't show a backtrace unlike Cirrus, but it should.

@matzbot matzbot requested a review from a team January 19, 2023 00:26
Copy link
Member

@XrXr XrXr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Waiting for cfg feature detection to be stabilized so we can call std::backtrace::Backtrace unconditionally in case we're building with Rust >=1.65.0. Or use https://doc.rust-lang.org/std/panic/fn.set_backtrace_style.html. I supposes we could put the code in right now and it'd work with nightly 🤔

@k0kubun k0kubun merged commit 4cf1d9b into ruby:master Jan 19, 2023
@k0kubun k0kubun deleted the yjit-backtrace branch January 19, 2023 01:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants