Ensure main file has default coverage if required. #7169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ioquatix
force-pushed
the
fix-coverage-of-main-file
branch
from
a700c34
to
bcfe633
Compare
mame
reviewed
Jan 23, 2023
| { | ||
| VALUE coverages = rb_get_coverages(); | ||
|
|
||
| if (RTEST(coverages)) { | ||
| iseq_setup_coverage(coverages, path, ast, 0); |
There was a problem hiding this comment.
@ioquatix Maybe you meant line_offset instead of 0? The parameter is not used. (I would be happy if you'll give me time to review it :-)
There was a problem hiding this comment.
Thanks, yeah it looks like a mistake. Sorry about not giving enough time for a review, I appreciate your feedback.
nurse
added a commit
to nurse/ruby
that referenced
this pull request
Jan 25, 2023
…Backport #19360] Ensure main file has default coverage if required. (ruby#7169) * Extract common code for coverage setup. --- iseq.c | 13 +++++++++++-- 1 file changed, 11 insertions(+), 2 deletions(-) More coverage tests & specs. (ruby#7171) * Add spec for eval and line coverage. * Add test for main file coverage. --- spec/ruby/library/coverage/start_spec.rb | 8 +++++++- test/coverage/autostart.rb | 2 ++ test/coverage/main.rb | 1 + test/coverage/test_coverage.rb | 7 +++++++ 4 files changed, 17 insertions(+), 1 deletion(-) create mode 100644 test/coverage/autostart.rb create mode 100644 test/coverage/main.rb
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugs.ruby-lang.org/issues/19360