Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC] Make changes to docs in ractor.rb #7180

Merged
merged 2 commits into from Jan 29, 2023
Merged

Conversation

luke-gru
Copy link
Contributor

Mainly English changes to make things more clear, and to fix minor non-idiomatic phrases.

ractor.rb Outdated Show resolved Hide resolved
ractor.rb Outdated Show resolved Hide resolved
ractor.rb Outdated Show resolved Hide resolved
ractor.rb Show resolved Hide resolved
ractor.rb Outdated Show resolved Hide resolved
ractor.rb Show resolved Hide resolved
Copy link
Member

@zzak zzak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor comments, otherwise LGTM. Thanks!

@nobu nobu added the Documentation Improvements to documentation. label Jan 24, 2023
@nobu nobu changed the title Make changes to docs in ractor.rb [DOC] Make changes to docs in ractor.rb Jan 24, 2023
@luke-gru
Copy link
Contributor Author

Thanks for the review, I'll make the adjustments.

Mainly English changes to make things more clear, and to fix minor
non-idiomatic phrases. Also clarified difference between frozen and
shareable objects.
@luke-gru
Copy link
Contributor Author

I made a few more changes, specifically to the section "Shareable and unshareable objects" because some of the information was confusing. Sorry that you'll have to go over it again 😩 I checked the work in html to make sure it looked nice and proper links were made.

@luke-gru
Copy link
Contributor Author

I made a new very small commit to fix up a few unnecessary self-referential links, and other small things. If/when you approve these new changes, I'll squash the commits.

@zzak zzak merged commit 4ffef59 into ruby:master Jan 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Improvements to documentation.
3 participants