Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure RUBY_YJIT_ENABLE only enables YJIT for truthy values #7208

Merged
merged 2 commits into from Jan 31, 2023
Merged

Make sure RUBY_YJIT_ENABLE only enables YJIT for truthy values #7208

merged 2 commits into from Jan 31, 2023

Conversation

maximecb
Copy link
Contributor

Addresses bug reported in: Shopify/yjit#309

@maximecb maximecb requested review from XrXr and k0kubun January 31, 2023 16:12
XrXr
XrXr approved these changes Jan 31, 2023
View reviewed changes
Copy link
Member

@XrXr XrXr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

ruby.c Outdated Show resolved Hide resolved
@maximecb @XrXr
Update ruby.c
3542082 
Co-authored-by: Alan Wu <XrXr@users.noreply.github.com>
@maximecb maximecb merged commit 4ce6426 into ruby:master Jan 31, 2023
@maximecb maximecb deleted the yjit_enable_truthy branch January 31, 2023 17:18
@andclt
Copy link

andclt commented Feb 28, 2024

Is it possible to get this backported to Ruby3.2?

@andclt andclt mentioned this pull request Feb 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@k0kubun k0kubun k0kubun approved these changes

@XrXr XrXr XrXr approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
4 participants
@maximecb @andclt @k0kubun @XrXr