Fix detection of compiler_wd in tool/update-deps #7331
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the large list of warnings at the top of the Check Dependencies CI run that look like this:
These warnings are being caused because
gcc
always outputsas the second line of the
*.i
file. There is already code inupdate-deps
with the intention of removing this line from the dependencies array, however it is not working as intendedThis is because when it loops through all the lines in the
*.i
files, it setsdep
each time, and setscompiler_wd ||= dep
. The use of||=
here means that thecompiler_wd
is always set to the first line in the file, rather than the second. Therefore the regex used to detect and remove the//
and set thecompile_wd
correctly is never matching.