Rename and move RB_GC_SAVE_MACHINE_CONTEXT #7465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
VM -> THREAD makes more sense for me because it takes a
BTW it saves registers for the GC marking, so I think it is GC specify code (this comment is not against the proposal). |
eightbitraptor
force-pushed
the
mvh-mv-save-machine-context
branch
from
a23afac
to
5930244
Compare
eightbitraptor
force-pushed
the
mvh-mv-save-machine-context
branch
from
5930244
to
5596e5f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This macro was originally a wrapper around
rb_gc_save_machine_context, a function inthread.c, but that function doesn't exist anymore and now this macro doesn't do anything GC specific.Because it's now being used from the context of the VM, or a thread. I've renamed it to
RB_VM_SAVE_MACHINE_CONTEXTand moved it intothread.h.