Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

YJIT: Bump SEND_MAX_DEPTH to 20 #7469

Merged
merged 2 commits into from Mar 10, 2023
Merged

YJIT: Bump SEND_MAX_DEPTH to 20 #7469

merged 2 commits into from Mar 10, 2023

Conversation

k0kubun
Copy link
Member

@k0kubun k0kubun commented Mar 7, 2023 •
edited

This reduced send_klass_megamorphic / side_exit_count from 15.0% to 8.0% on SFR.

I needed to fix Type::BlockParamProxy to be is_heap() => true (indeed it is. it's a special "object") to pass test_objectspace.rb with --yjit-verify-ctx and this threshold.

@k0kubun k0kubun marked this pull request as ready for review March 10, 2023 01:03
@matzbot matzbot requested a review from a team March 10, 2023 01:04
@maximecb maximecb merged commit 83f6eee into ruby:master Mar 10, 2023
@k0kubun k0kubun deleted the yjit-max-depth-20 branch March 10, 2023 22:57
@k0kubun k0kubun mentioned this pull request Sep 2, 2023
Merged
@casperisfine casperisfine mentioned this pull request Sep 6, 2023
Merged
@k0kubun k0kubun mentioned this pull request Sep 7, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
2 participants
@k0kubun @maximecb