YJIT: Save PC on rb_str_concat #7586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k0kubun
force-pushed
the
yjit-fix-concat
branch
2 times, most recently
from
16ebb61
to
c81e8b9
Compare
[Bug #19483] Co-authored-by: Alan Wu <alansi.xingwu@shopify.com>
k0kubun
force-pushed
the
yjit-fix-concat
branch
from
c81e8b9
to
97c162d
Compare
maximecb
approved these changes
Mar 23, 2023
matzbot
pushed a commit
that referenced
this pull request
Jul 16, 2023
…Backport #19483] YJIT: Protect strings from GC on String#<< (#7466) Fix Shopify/yjit#310 [Bug #19483] Co-authored-by: Maxime Chevalier-Boisvert <maxime.chevalierboisvert@shopify.com> Co-authored-by: Jimmy Miller <jimmy.miller@shopify.com> --- yjit/src/codegen.rs | 3 +++ 1 file changed, 3 insertions(+) YJIT: Save PC on rb_str_concat (#7586) [Bug #19483] Co-authored-by: Alan Wu <alansi.xingwu@shopify.com> --- test/ruby/test_yjit.rb | 19 +++++++++++++++++++ yjit/src/codegen.rs | 6 ++++-- 2 files changed, 23 insertions(+), 2 deletions(-)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix Shopify#514
[Bug #19483]
make test-all TESTS="test/ruby/test_m17n_comb.rb -n /test_str_concat/" RUN_OPTS="--yjit-call-threshold=1"crashes without this, and this change fixes it. Also this PR includes a test case that trips assertion on dev build.