Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

YJIT: Fix a warning on cargo test #7909

Merged
merged 1 commit into from
Jun 5, 2023
Merged

Conversation

k0kubun
Copy link
Member

@k0kubun k0kubun commented Jun 5, 2023

This PR fixes the following warning:

$ cargo test --all-features
   Compiling yjit v0.1.0 (/home/k0kubun/src/github.com/ruby/ruby/yjit)
warning: unused variable: `exit_pc`
   --> src/stats.rs:615:45
    |
615 | pub extern "C" fn rb_yjit_record_exit_stack(exit_pc: *const VALUE)
    |                                             ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_exit_pc`
    |
    = note: `#[warn(unused_variables)]` on by default

It's conditionally used for #[cfg(not(test))], so it currently becomes a warning on cargo test.

@matzbot matzbot requested a review from a team June 5, 2023 21:08
@k0kubun k0kubun merged commit ebe1077 into ruby:master Jun 5, 2023
94 of 96 checks passed
@k0kubun k0kubun deleted the yjit-warning branch June 5, 2023 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants