Fix memory leak in Ripper #7985
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
def test_no_memory_leak
assert_no_memory_leak([], "#{<<-"begin;"}", "#{<<-'end;'}", rss: true)
require "ripper"
code = ""
1_000.times do
Ripper.parse(code)
end
begin;
1_000_000.times do
Ripper.parse(code)
end
end;
end |
nobu
approved these changes
Jun 28, 2023
|
The error should be https://bugs.ruby-lang.org/issues/19748. |
peterzhu2118
force-pushed
the
pz-ripper-mem-leak
branch
from
5dff81b
to
30c28ff
Compare
The following script leaks memory in Ripper:
```ruby
require "ripper"
20.times do
100_000.times do
Ripper.parse("")
end
puts `ps -o rss= -p #{$$}`
end
```
peterzhu2118
force-pushed
the
pz-ripper-mem-leak
branch
from
30c28ff
to
035225d
Compare
nobu
reviewed
Jun 28, 2023
Comment on lines
+146
to
+148
| 10_000_000.times do | ||
| Ripper.parse("") | ||
| end |
There was a problem hiding this comment.
On my machine (Intel MacBookPro 2019), this caused timeouts both of before and after this commit.
There was a problem hiding this comment.
It doesn't time out on my M1 MacBook Pro, but I can reproduce on my Linux machine. I opened #7992 which should fix it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following script leaks memory in Ripper: