Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce script_lines function for refactor #7990

Merged
merged 1 commit into from
Jul 1, 2023
Merged

Introduce script_lines function for refactor #7990

merged 1 commit into from
Jul 1, 2023

Conversation

S-H-GAMELINKS
Copy link
Contributor

Introduce script_lines_with macro for refactor script_lines_defined and script_lines_get functions

@nobu
Copy link
Member

nobu commented Jun 28, 2023

Isn't it better to extract a function returns script_lines?

@S-H-GAMELINKS S-H-GAMELINKS force-pushed the introduce/script_lines_with_macro branch from 75d145c to c237b22 Compare June 28, 2023 12:54
@S-H-GAMELINKS S-H-GAMELINKS changed the title Introduce script_lines_with macro for refactor Introduce script_lines function for refactor Jun 28, 2023
nobu
nobu reviewed Jun 29, 2023
View reviewed changes
parse.y Outdated
{
ID script_lines;
ID script_lines; \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
ID script_lines; \
ID script_lines;

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, fixed it in 83d6792

@S-H-GAMELINKS S-H-GAMELINKS force-pushed the introduce/script_lines_with_macro branch from c237b22 to 83d6792 Compare June 29, 2023 10:10
@S-H-GAMELINKS S-H-GAMELINKS requested a review from nobu June 29, 2023 14:49
@S-H-GAMELINKS S-H-GAMELINKS force-pushed the introduce/script_lines_with_macro branch from 83d6792 to b47fa23 Compare June 30, 2023 13:51
@nobu nobu merged commit 3fd1968 into ruby:master Jul 1, 2023
92 checks passed
@S-H-GAMELINKS S-H-GAMELINKS deleted the introduce/script_lines_with_macro branch July 1, 2023 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nobu nobu Awaiting requested review from nobu

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
2 participants
@S-H-GAMELINKS @nobu