Increase memory leak test timeout #7992
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nobu
reviewed
Jun 28, 2023
test/ripper/test_ripper.rb
Outdated
| @@ -142,7 +142,7 @@ def test_dedent_string | |||
| end | |||
|
|
|||
| def test_no_memory_leak | |||
| assert_no_memory_leak(%w(-rripper), "", "#{<<~'end;'}", rss: true) | |||
| assert_no_memory_leak(%w(-rripper), "", "#{<<~'end;'}", rss: true, timeout: 60) | |||
There was a problem hiding this comment.
This test consumes 22 secs.
Repeating 10M times is needed?
There was a problem hiding this comment.
I changed it to 2M times. At 1M times, the test doesn't work on my M1 MacBook Pro (but works on my x86 Linux machine). 2M times is the minimum for my M1.
peterzhu2118
force-pushed
the
ripper-mem-leak-test-timeout
branch
from
8c55a78
to
7e40cd0
Compare
The test times out on some platforms, so increase the timeout.
peterzhu2118
force-pushed
the
ripper-mem-leak-test-timeout
branch
from
7e40cd0
to
1927c15
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test times out on some platforms, so increase the timeout.