Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC] Dir doc #8014

Merged
merged 5 commits into from Jul 4, 2023
Merged

[DOC] Dir doc #8014

merged 5 commits into from Jul 4, 2023

Conversation

BurdetteLamar
Copy link
Member

The link at line 304 is fouled by the expression in line 302. I don't know why, and I don't have a workaround.

@BurdetteLamar BurdetteLamar added the Documentation Improvements to documentation. label Jul 2, 2023
dir.rb Outdated Show resolved Hide resolved
dir.rb Outdated Show resolved Hide resolved
dir.rb Outdated Show resolved Hide resolved
Comment on lines -151 to -153
# Note that the pattern is not a regexp, it's closer to a shell glob.
# See File::fnmatch for the meaning of the +flags+ parameter.
# Case sensitivity depends on your system (+File::FNM_CASEFOLD+ is ignored).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should talk about the possible flags found in File::Constants.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had not known where FNM_* were.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should list the flags under File::Constants that can be used in this method.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, but out of scope for this PR?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok I guess it's fair that this isn't causing a regression

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@peterzhu2118, I will not forget about your suggestion.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@peterzhu2118, which flags in File::Constants apply for Dir.glob? I tried a couple of unlikelies (TRUNC, CREAT) and got no error.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like invalid flags just get silently ignored.

@peterzhu2118 peterzhu2118 merged commit 2e6a8a8 into ruby:master Jul 4, 2023
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Improvements to documentation.
2 participants