Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

YJIT: increase max chain depth for expandarray #8205

Merged
merged 1 commit into from
Aug 11, 2023

Conversation

maximecb
Copy link
Contributor

Expand the chain depth from 2 to 4 since this gets tripped some percentage of the time on SFR:

expandarray exit reasons: 
       chain_max_depth:  1,345,017 (85.0%)
                 splat:    181,665 (11.5%)
             not_array:     54,494 ( 3.4%)
    comptime_not_array:        507 ( 0.0%)

...

Top-20 most frequent exit ops (100.0% of exits):
                    checkmatch:  8,593,546 (36.0%)
                   invokesuper:  4,080,558 (17.1%)
                 setlocal_WC_0:  3,828,583 (16.1%)
            getblockparamproxy:  1,778,545 ( 7.5%)
                   expandarray:  1,581,683 ( 6.6%)
        opt_send_without_block:  1,366,974 ( 5.7%)
          opt_getconstant_path:  1,328,064 ( 5.6%)
                 opt_aset_with:    362,129 ( 1.5%)
                      opt_aref:    352,641 ( 1.5%)

@matzbot matzbot requested a review from a team August 11, 2023 15:18
@noahgibbs
Copy link
Contributor

Makes sense. LGTM.

@maximecb maximecb merged commit b6c6660 into ruby:master Aug 11, 2023
91 of 93 checks passed
@maximecb maximecb deleted the yjit_expandarray_depth branch August 11, 2023 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants