New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

YJIT: Chain guard classes on instance_of #8209

Merged

maximecb merged 1 commit into ruby:master from k0kubun:yjit-chain-instanceof

Aug 14, 2023

Member

k0kubun commented Aug 11, 2023

guard_send_instance_of_class_mismatch is the top method call exit reason on SFR:

method call exit reasons: 
     instance_of_class_mismatch:    177,776 (40.2%)
          send_chain_not_string:    119,495 (27.0%)
            is_a_class_mismatch:     65,474 (14.8%)
                    interrupted:     46,571 (10.5%)
                    not_fixnums:     32,070 ( 7.3%)
    splatarray_length_not_equal:        656 ( 0.1%)

I'd like to see if a chain guard helps the situation.


          YJIT: Chain guard classes on instance_of

ee730c3

matzbot requested a review from a team

August 11, 2023 23:05

maximecb merged commit 75c9487 into ruby:master

93 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment