YJIT: Fix return type of Integer#/ with T_FIXNUM inputs #8250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue found by running ruby/spec with `--yjit-verify-ctx`. Thanks!
maximecb
approved these changes
Aug 18, 2023
|
Is this related to the error reported by Kokubun? https://github.com/ruby/ruby/actions/runs/5896874188/job/15995521718 |
|
This is definitely more correct, but I wonder if it will have knock-on effects with performance. (Edit to add: but we should still 100% do it. Incorrect is bad.) |
Probably not, the code in the stack trace don't use division. I was trying to recreate that failure locally and ran into this issue instead. I also found another |
Unlikely because division is fairly rare in practice. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue found by running ruby/spec with
--yjit-verify-ctx. Thanks!