Fix support for dynamic keys. #8273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ioquatix
force-pushed
the
fiber-storage-dynamic-keys
branch
from
552bc6f
to
4bcfb37
Compare
ioquatix
force-pushed
the
fiber-storage-dynamic-keys
branch
from
4bcfb37
to
ad3f1af
Compare
nobu
approved these changes
Aug 24, 2023
|
👍 it should only allow Symbols, I think that's how we discussed it in the past, and so much simpler. |
|
Yeah, totally agree in retrospect. I monkey patched a fix in my |
nagachika
added a commit
to nagachika/ruby
that referenced
this pull request
Sep 30, 2023
Fix support for dynamic keys. (ruby#8273) * Skip RBS test. --- cont.c | 8 +++----- spec/ruby/core/fiber/storage_spec.rb | 14 ++++++++++++++ tool/rbs_skip_tests | 2 ++ 3 files changed, 19 insertions(+), 5 deletions(-)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately there is a bug in
Fiber[key] = valuewhen key is dynamically defined. I didn't fully understand the implementation ofrb_check_id.https://bugs.ruby-lang.org/issues/19845