Fix io_buffer_get_string default length computation.
#8427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When an offset bigger than the size is given, the resulting length will be computed incorrectly. Raise an argument error in this case.
ioquatix
force-pushed
the
io-buffer-get_string-validations
branch
from
3dde22e
to
21997a5
Compare
ioquatix
force-pushed
the
io-buffer-get_string-validations
branch
from
d5fafac
to
ac8e063
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an offset bigger than the size is given, the resulting length will be computed incorrectly. Raise an argument error in this case.
Conversion from
VALUEtosize_trequires special consideration, so I'll write helpers.