Refactor rb_obj_evacuate_ivs_to_hash_table
#8934
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
That function is a bit too low level to called from multiple
places. It's always used in tandem with `rb_shape_set_too_complex`
and both have to know how the object is laid out to update the
`iv_ptr`.
So instead we can provide two higher level function:
- `rb_obj_copy_ivs_to_hash_table` to prepare a `st_table` from an
arbitrary oject.
- `rb_obj_convert_to_too_complex` to assign the new `st_table`
to the old object, and safely free the old `iv_ptr`.
Unfortunately both can't be combined into one, because `rb_obj_copy_ivar`
need `rb_obj_copy_ivs_to_hash_table` to copy from one object
to another.
casperisfine
force-pushed
the
refactor-rb_obj_evacuate_ivs_to_hash_table
branch
from
5c86bd3
to
ac8fdf0
Compare
byroot
requested review from
tenderlove,
peterzhu2118,
jemmaissroff and
XrXr
and removed request for
tenderlove
peterzhu2118
approved these changes
Nov 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That function is a bit too low level to called from multiple places. It's always used in tandem with
rb_shape_set_too_complexand both have to know how the object is laid out to update theiv_ptr.So instead we can provide two higher level function:
rb_obj_copy_ivs_to_hash_tableto prepare ast_tablefrom an arbitrary oject.rb_obj_convert_to_too_complexto assign the newst_tableto the old object, and safely free the oldiv_ptr.Unfortunately both can't be combined into one, because
rb_obj_copy_ivarneedrb_obj_copy_ivs_to_hash_tableto copy from one object to another.