Update string and xstring encodings #9142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jemmaissroff
approved these changes
Dec 6, 2023
paracycle
reviewed
Dec 6, 2023
| @@ -4212,9 +4212,9 @@ pm_encoding_shift_jis_char_width(const uint8_t *b, ptrdiff_t n) { | |||
| } | |||
|
|
|||
| /** | |||
| * This is the definition of all of the encodings that we support. | |||
| * This is the table of all of the encodings that prisms supports. | |||
There was a problem hiding this comment.
Suggested change
| * This is the table of all of the encodings that prisms supports. | |
| * This is the table of all of the encodings that prism supports. |
There was a problem hiding this comment.
These changes are on prism's side, so I'll update them there.
paracycle
reviewed
Dec 6, 2023
| } pm_encoding_type_t; | ||
|
|
||
| /** | ||
| * This is the default UTF-8 encoding. We need it to quickly create parsers. | ||
| * This is the table of all of the encodings that prisms supports. |
There was a problem hiding this comment.
Suggested change
| * This is the table of all of the encodings that prisms supports. | |
| * This is the table of all of the encodings that prism supports. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This merges ruby/prism#1990 and correctly sets encodings for string and xstring nodes. It does not set the correct encoding for individual pieces of interpolated string and interpolated xstring nodes, only because I want to get this merged first and then figure out what is missing.