Extract base64 as bundled gems #9550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yahonda
added a commit
to yahonda/rubyntlm
that referenced
this pull request
Jan 29, 2024
because `base64` is bundled gem since Ruby 3.4.0dev. ruby/ruby#9550 https://bugs.ruby-lang.org/issues/20187
M-Yamashita01
added a commit
to M-Yamashita01/jbuilder
that referenced
this pull request
May 17, 2024
This commit adds base64 gem to rails_6_0, rails_6_1 and rails_7_0 gemfiles in gemfiles directory and jbuilder.gemspec for the following reasons. - Starting from Ruby 3.3, using base64 raises the following warning. > warning: base64 was loaded from the standard library, but will no longer be part of the default gems since Ruby 3.4.0. Add base64 to your Gemfile or gemspec. Also contact author of activesupport-6.0.6.1 to add base64 into its gemspec. Refer to https://bugs.ruby-lang.org/issues/20187 ruby/ruby#9550
M-Yamashita01
added a commit
to M-Yamashita01/jbuilder
that referenced
this pull request
May 17, 2024
This commit adds base64 gem to rails_6_0, rails_6_1 and rails_7_0 gemfiles in gemfiles directory and jbuilder.gemspec for the following reasons. - Starting from Ruby 3.3, using base64 raises the following warning. > warning: base64 was loaded from the standard library, but will no longer be part of the default gems since Ruby 3.4.0. Add base64 to your Gemfile or gemspec. Also contact author of activesupport-6.0.6.1 to add base64 into its gemspec. - The reason for not adding gems to rails7_1.gemfiles and rails_head.gemfiles is that the base64 gem has been added to activesupport.gemspec since ActiveSupport 7.1 with add_dependency. - The reason for adding the gem to jbuiilder.gemfiles is that the developer may be using Ruby 3.3 and less than Rails 7.1. Refer to https://bugs.ruby-lang.org/issues/20187 ruby/ruby#9550 https://github.com/rails/rails/blob/v7.1.0/activesupport/activesupport.gemspec
M-Yamashita01
added a commit
to M-Yamashita01/jbuilder
that referenced
this pull request
May 17, 2024
This commit adds base64 gem to rails_6_0.gemfiles, rails_6_1.gemfiles and rails_7_0.gemfiles in gemfiles directory and jbuilder.gemspec for the following reasons. - Starting from Ruby 3.3, using base64 raises the following warning. > warning: base64 was loaded from the standard library, but will no longer be part of the default gems since Ruby 3.4.0. Add base64 to your Gemfile or gemspec. Also contact author of activesupport-6.0.6.1 to add base64 into its gemspec. - The reason for not adding gems to rails7_1.gemfiles and rails_head.gemfiles is that the base64 gem has been added to activesupport.gemspec since ActiveSupport 7.1 with add_dependency. - The reason for adding the gem to jbuiilder.gemfiles is that the developer may be using Ruby 3.3 and less than Rails 7.1. Refer to https://bugs.ruby-lang.org/issues/20187 ruby/ruby#9550 https://github.com/rails/rails/blob/v7.1.0/activesupport/activesupport.gemspec
This was referenced May 17, 2024
M-Yamashita01
added a commit
to M-Yamashita01/jbuilder
that referenced
this pull request
May 23, 2024
This commit adds base64 gem to rails_6_0.gemfiles, rails_6_1.gemfiles and rails_7_0.gemfiles in gemfiles directory for the following reasons. - Starting from Ruby 3.3, using base64 raises the following warning. > warning: base64 was loaded from the standard library, but will no longer be part of the default gems since Ruby 3.4.0. Add base64 to your Gemfile or gemspec. Also contact author of activesupport-6.0.6.1 to add base64 into its gemspec. - The reason for not adding gems to rails7_1.gemfiles and rails_head.gemfiles is that the base64 gem has been added to activesupport.gemspec since ActiveSupport 7.1 with add_dependency. However, we do not add base64 gem to jbuilder.gemspec for the following reason. - jbuilder supports Ruby 2.2, but initial version (v0.1.0) of base64 gem supports Ruby 2.3 and above. Therefore if we add base64 to jbuilder.gemspec, it fails while running the `bundle install` command. Refer to https://bugs.ruby-lang.org/issues/20187 ruby/ruby#9550 https://github.com/rails/rails/blob/v7.1.0/activesupport/activesupport.gemspec https://github.com/ruby/base64/blob/v0.1.0/base64.gemspec
M-Yamashita01
added a commit
to M-Yamashita01/jbuilder
that referenced
this pull request
May 23, 2024
This commit adds base64 gem to rails_6_0.gemfiles, rails_6_1.gemfiles and rails_7_0.gemfiles in gemfiles directory for the following reasons. - Starting from Ruby 3.3, using base64 raises the following warning. > warning: base64 was loaded from the standard library, but will no longer be part of the default gems since Ruby 3.4.0. Add base64 to your Gemfile or gemspec. Also contact author of activesupport-6.0.6.1 to add base64 into its gemspec. - The reason for not adding gems to rails7_1.gemfiles and rails_head.gemfiles is that the base64 gem has been added to activesupport.gemspec since ActiveSupport 7.1 with add_dependency. However, we do not add base64 gem to jbuilder.gemspec for the following reason. - jbuilder supports Ruby 2.2, but initial version (v0.1.0) of base64 gem supports Ruby 2.3 and above. Therefore if we add base64 to jbuilder.gemspec, it fails while running the `bundle install` command. Refer to https://bugs.ruby-lang.org/issues/20187 ruby/ruby#9550 https://github.com/rails/rails/blob/v7.1.0/activesupport/activesupport.gemspec https://github.com/ruby/base64/blob/v0.1.0/base64.gemspec
pcai
pushed a commit
to WinRb/rubyntlm
that referenced
this pull request
Jun 6, 2024
because `base64` is bundled gem since Ruby 3.4.0dev. ruby/ruby#9550 https://bugs.ruby-lang.org/issues/20187
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugs.ruby-lang.org/issues/20187