Merge https://github.com/rubygems/rubygems/pull/7379 #9604
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stanhu
added a commit
to stanhu/rubygems
that referenced
this pull request
Jan 19, 2024
CI broke in ruby/ruby#9604 because if any Ruby tests run `require 'net/http'`, they will pollute the `$LOADED_FEATURES` for the RubyGems tests. We can fix this by renaming the test default gem from `net-http` to `my-http`.
4 tasks
stanhu
added a commit
to stanhu/rubygems
that referenced
this pull request
Jan 19, 2024
CI broke in ruby/ruby#9604 because if any Ruby tests run `require 'net/http'`, they will pollute the `$LOADED_FEATURES` for the RubyGems tests. We can fix this by renaming the test default gem from `net-http` to `my-http`. See rubygems#7379 (comment) for more details.
stanhu
added a commit
to stanhu/rubygems
that referenced
this pull request
Jan 19, 2024
CI broke in ruby/ruby#9604 because if any Ruby tests run `require 'net/http'`, they will pollute the `$LOADED_FEATURES` for the RubyGems tests. We can fix this by renaming the test default gem from `net-http` to `my-http`. See rubygems#7379 (comment) for more details.
stanhu
added a commit
to stanhu/rubygems
that referenced
this pull request
Jan 19, 2024
CI broke in ruby/ruby#9604 because if any Ruby tests run `require 'net/http'`, they will pollute the `$LOADED_FEATURES` for the RubyGems tests. We can fix this by renaming the test default gem from `net-http` to `my-http`. See rubygems#7379 (comment) for more details.
|
rubygems/rubygems#7405 should make these tests pass again. |
CI broke in ruby#9604 because if any Ruby tests run `require 'net/http'`, they will pollute the `$LOADED_FEATURES` for the RubyGems tests. We can fix this by renaming the test default gem from `net-http` to `my-http`. See rubygems/rubygems#7379 (comment) for more details.
|
@stanhu Thanks. I applied your patch to this branch. After passing test, I will merge your change on this and rubygems repositories. |
hsbt
pushed a commit
to hsbt/ruby
that referenced
this pull request
Jan 24, 2024
CI broke in ruby#9604 because if any Ruby tests run `require 'net/http'`, they will pollute the `$LOADED_FEATURES` for the RubyGems tests. We can fix this by renaming the test default gem from `net-http` to `my-http`. See rubygems/rubygems#7379 (comment) for more details.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 5, 2024
* Merge RubyGems-3.5.4 and Bundler-2.5.4 * Merge RubyGems-3.5.5 and Bundler-2.5.5 * Make tests play with upstream Ruby tests CI broke in #9604 because if any Ruby tests run `require 'net/http'`, they will pollute the `$LOADED_FEATURES` for the RubyGems tests. We can fix this by renaming the test default gem from `net-http` to `my-http`. See rubygems/rubygems#7379 (comment) for more details. --------- Co-authored-by: Stan Hu <stanhu@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rubygems/rubygems#7379 (comment)
cc @deivid-rodriguez