Add an autoload spec for the behavior inside autoload but after the constant is defined #9613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
casperisfine
force-pushed
the
autoload-spec-after-const-defined
branch
from
a9b85fa
to
a34eb22
Compare
eregon
reviewed
Jan 22, 2024
|
BTW it would be great to also test the case of the constant is set and then an exception happens in the autoload. |
casperisfine
force-pushed
the
autoload-spec-after-const-defined
branch
from
a34eb22
to
3c9bc2a
Compare
…onstant is defined
casperisfine
force-pushed
the
autoload-spec-after-const-defined
branch
from
3c9bc2a
to
5a090a9
Compare
|
I fixed the naming issues. I'll look into the error thing but no promises. |
eregon
approved these changes
Jan 22, 2024
|
❤️ I'll have a stab at the spec for the error. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From discussion on https://bugs.ruby-lang.org/issues/20188
cc @fxn @eregon