[PRISM] Fix error handling in pm_parse_prism
#9862
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kddnewton
requested changes
Feb 6, 2024
prism_compile.c
Outdated
| int e = errno; | ||
| #endif | ||
|
|
||
| rb_syserr_fail(e, RSTRING_PTR(filepath)); |
There was a problem hiding this comment.
We want to return an error from this function so that callers can do cleanup (free anything they allocated). Could you create the error from this function and return it instead?
There was a problem hiding this comment.
Oh no, I didn't even remove the following line. OK I think this is fixed now.
Following changes made in ruby/prism#2365 this implements error handling for when `pm_string_mapped_init` returns `false`. Related: ruby/prism#2207
eileencodes
force-pushed
the
prism-improve-error-handling-2207
branch
from
dae5753
to
4cdb74c
Compare
kddnewton
approved these changes
Feb 7, 2024
|
Nice looks great! Thanks @eileencodes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following changes made in ruby/prism#2365 this implements error handling for when
pm_string_mapped_initreturnsfalse.Related: ruby/prism#2207