YJIT: Add support for **kwrest parameters
#9891
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that `...` uses `**kwrest` instead of regular splat and ruby2keywords, we need to support these type of methods to support `...` well.
maximecb
approved these changes
Feb 9, 2024
k0kubun
reviewed
Feb 10, 2024
|
|
||
| // Build the keyword rest parameter hash before we make any changes to the order of | ||
| // the supplied keyword arguments | ||
| if has_kwrest { |
There was a problem hiding this comment.
Do you think it makes sense to carve out the kwrest logic as a separate function? It's generally hard to follow the sequence of operations in gen_send_iseq, so I wonder if it makes it easier to understand what happens after what in that function.
There was a problem hiding this comment.
Make sense. I think we should move all the keywords handling out, though. I'll make a PR.
k0kubun
approved these changes
Feb 10, 2024
This was referenced Feb 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that
...uses**kwrestinstead of regular splat andruby2keywords, we need to support these type of methods to
support
...well.On
lobsters, this cutsnum_send_dynamicby ~1%: