-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
YJIT: Add top ISEQ call counts to --yjit-stats #9906
Conversation
d1b8c63
to
7db6376
Compare
7db6376
to
04b07a7
Compare
Good idea. I realize this might be annoying to format, but could you also report the full path and line number for ISEQs? Would make it easy to find and go look at the ISEQs. |
In that case, this is the format I want to use 34f4c36, which is the same format as
This format allows you to naturally print Ruby blocks, which was not possible with the previous format. I flipped the left and the right of the top-X tables since the label name is way too long to be on the left. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👌
This is the same as #9047 but for ISEQ.
I think it's useful to have the counter for ISEQs when we think about inlining ISEQs. It's also easier to use in production than TracePoint-based counters like Shopify/yjit-bench#163.