YJIT: Replace perf_fn! with a simpler macro #9971
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k0kubun
force-pushed
the
yjit-perf-fn
branch
from
9ded70e
to
a2ef9cb
Compare
XrXr
approved these changes
Feb 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up on #9957
The
perf_fn!macro was useful to make sure every such call is profiled. However, VSCode (rust-analyzer) doesn't support showing the function name when you're a inside a macro (perf_fn!), and that makes it harder to read code for me.This PR adds
perf_call!macro that needs to be used by the caller. It has the risk of leaving un-profiled calls, but we don't add calls of these functions that often, so I think it's acceptable. This macro is useful when you want to add a prefix too.