remove support for obsolete Prime.new #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| it "raises a ArgumentError when is called with some arguments" do | ||
| lambda { Prime.new(1) }.should raise_error(ArgumentError) | ||
| lambda { Prime.instance(1) }.should raise_error(ArgumentError) | ||
| end |
There was a problem hiding this comment.
This file should be removed and merged with instance_spec.rb.
There was a problem hiding this comment.
All the cases in new_spec are covered in instance_spec.rb, so we can remove the file without merging.
There was a problem hiding this comment.
Perfect then! Can you remove it?
There was a problem hiding this comment.
Yeah! I will commit in sometime
|
Looks good! Sorry for replying late. |
|
Thank you for the review! Sure, I make the changes. |
|
Thank you for your contribution, it's much appreciated! |
eregon
added a commit
that referenced
this pull request
May 18, 2015
remove support for obsolete Prime.new
284km
added a commit
to 284km/doctree
that referenced
this pull request
Feb 26, 2018
Prime.new was removed in 2.3.0 ruby/ruby#891 ruby/spec#63
284km
added a commit
to 284km/doctree
that referenced
this pull request
Feb 26, 2018
Prime.new was removed in 2.3.0 ruby/ruby#891 ruby/spec#63
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
deprecate Prime.new