Remove object_id
use in Set#flatten
#34
Open
+3
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found this while auditing uses of
object_id
inruby/ruby
. Pulled out from ruby/ruby#9276.This PR replaces look-ups into a
Set
byobject_id
s, with an identity Set (seeSet#compare_by_identity
). This has the same semantics but is faster and doesn't trigger allocation of IDs for these objects.