Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jruby and bundler-cache: true not playing nicely together #72

Closed
JacobEvelyn opened this issue Jul 30, 2020 · 8 comments
Closed

jruby and bundler-cache: true not playing nicely together #72

JacobEvelyn opened this issue Jul 30, 2020 · 8 comments

Comments

@JacobEvelyn
Copy link

It's possible I'm doing something wrong, but I just tried using the bundler-cache: true option and found that it works fine for MRI rubies but for jruby it runs bundle install fine, but then when we run bundle exec rspec we get:

bundler: failed to load command: rspec

(rspec is in the Gemfile.) What am I missing?

@eregon
Copy link
Member

eregon commented Jul 30, 2020

Do you have an example workflow run where it fails?

@JacobEvelyn
Copy link
Author

Yes, sorry for not linking earlier. Here's the workflow change I'm attempting to make, and here's the result.

@eregon
Copy link
Member

eregon commented Jul 30, 2020

Can you try to reproduce locally on JRuby? This sounds like a JRuby bug.

And in previous runs such as https://github.com/panorama-ed/memo_wise/runs/928059400?check_suite_focus=true RuboCop was skipped on JRuby.

@eregon
Copy link
Member

eregon commented Jul 30, 2020

But on https://github.com/panorama-ed/memo_wise/runs/925094050?check_suite_focus=true it worked, interesting.
But the cache key in that run doesn't seem very good, it's not per Ruby version:

       key: ${{ runner.os }}-gems-${{ hashFiles('**/Gemfile.lock') }}

Could you try to run that again (so based on memo_wise master) but without the cache step?

@JacobEvelyn
Copy link
Author

Could you try to run that again (so based on memo_wise master) but without the cache step?

Sure! I just pushed a new commit to that testing branch, and it ran successfully, making me think the issue is somewhere in ruby/setup-ruby. Let me know what else I can do to help debug this!

@eregon
Copy link
Member

eregon commented Aug 1, 2020

It's a bug of JRuby, I could reproduce it locally: jruby/jruby#6349

@eregon eregon closed this as completed Aug 1, 2020
@JacobEvelyn
Copy link
Author

Thank you!

@headius
Copy link
Contributor

headius commented Aug 3, 2020

This is not a bug of JRuby. It is a bug of Bundler.

jruby/jruby#6349 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants