Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for macos-14 #542

Closed
wants to merge 1 commit into from

Conversation

volatilegg
Copy link

@volatilegg volatilegg commented Oct 27, 2023

Motivation

Adding macos-14 image to the support list to avoid error if the runner is using macos-14

Error: The current runner (macos-14-x64) was detected as self-hosted because the platform does not match a GitHub-hosted runner image (or that image is deprecated and no longer supported).

@eregon
Copy link
Member

eregon commented Oct 27, 2023

https://docs.github.com/en/actions/using-github-hosted-runners/about-github-hosted-runners/about-github-hosted-runners#supported-runners-and-hardware-resources does not include macos-14.
I found actions/runner-images#7508 which confirms it's not yet supported for GitHub-hosted runners.
So I guess you are using a self-hosted runner?

The problem is macos-14 cannot be tested in CI here, maybe it works, maybe not and it cannot really be supported if it's not tested.

@volatilegg
Copy link
Author

@eregon Thanks for the quick reply
Yes, this is blocking me on a self-hosted runner 😓
We're trying to push the changes on a temp action, will update here once it works
https://github.com/marketplace/actions/setup-ruby-temp?version=v.1.160.0

@volatilegg volatilegg marked this pull request as draft October 27, 2023 14:13
@eregon
Copy link
Member

eregon commented Oct 27, 2023

I think for macOS & Windows, where in both cases we use builds on the oldest available GH-hosted runners we could let the action detect that case (self-hosted + version more recent than in GH-hosted runners) and continue, and just warn in its output about this case not being tested.

For Linux that's not an option as we have different builds for each OS version.

@eregon
Copy link
Member

eregon commented Oct 27, 2023

BTW you don't need to publish the release to the marketplace to try your action, just a tag or branch is enough.
In fact I think it's best to avoid publishing the release to the marketplace to avoid confusion here.

@volatilegg
Copy link
Author

@eregon Oh thank you, I didn't know that :D
And delisted the temp one on marketplace

@eregon
Copy link
Member

eregon commented Dec 27, 2023

I'll close this because that's not the correct way to fix this (macos-14 is not a GitHubHostedPlatforms).

I would welcome a PR to do #542 (comment) though.

@eregon eregon closed this Dec 27, 2023
@icecoffin
Copy link

macOS 14 is now available on GitHub hosted runners (actions/runner-images#7508). Could this PR be reopened and merged?

@eregon
Copy link
Member

eregon commented Jan 31, 2024

Will be done in #567 instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants